From: YueHaibing <yuehaibing@huawei.com>
Date: Mon, 23 Jul 2018 08:33:19 +0000 (+0800)
Subject: ipv6: sr: Use kmemdup instead of duplicating it in parse_nla_srh
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7fa41efac14ffbe8db7660ad2da3928969d10caf;p=linux.git

ipv6: sr: Use kmemdup instead of duplicating it in parse_nla_srh

Replace calls to kmalloc followed by a memcpy with a direct call to
kmemdup.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c
index cd6e4cab63f6c..e1025b493a185 100644
--- a/net/ipv6/seg6_local.c
+++ b/net/ipv6/seg6_local.c
@@ -637,12 +637,10 @@ static int parse_nla_srh(struct nlattr **attrs, struct seg6_local_lwt *slwt)
 	if (!seg6_validate_srh(srh, len))
 		return -EINVAL;
 
-	slwt->srh = kmalloc(len, GFP_KERNEL);
+	slwt->srh = kmemdup(srh, len, GFP_KERNEL);
 	if (!slwt->srh)
 		return -ENOMEM;
 
-	memcpy(slwt->srh, srh, len);
-
 	slwt->headroom += len;
 
 	return 0;