From: Kent Overstreet <kent.overstreet@linux.dev>
Date: Fri, 3 May 2024 14:55:17 +0000 (-0400)
Subject: bcachefs: don't free error pointers
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7ffec9ccdc6ad8356792f9a7823b1fe9c8a10cbf;p=linux.git

bcachefs: don't free error pointers

Reported-by: syzbot+3333603f569fc2ef258c@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/recovery.c b/fs/bcachefs/recovery.c
index be5b476193270..8091d0686029f 100644
--- a/fs/bcachefs/recovery.c
+++ b/fs/bcachefs/recovery.c
@@ -902,7 +902,8 @@ out:
 		bch2_journal_keys_put_initial(c);
 		bch2_find_btree_nodes_exit(&c->found_btree_nodes);
 	}
-	kfree(clean);
+	if (!IS_ERR(clean))
+		kfree(clean);
 
 	if (!ret &&
 	    test_bit(BCH_FS_need_delete_dead_snapshots, &c->flags) &&