From: Christoph Hellwig Date: Mon, 24 Jul 2023 16:54:31 +0000 (-0700) Subject: block: downgrade a bio_full call in bio_add_page X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=80232b520314214d846eb0a65faef8b51b702fa7;p=linux.git block: downgrade a bio_full call in bio_add_page bio_add_page already checks that there is space in bi_size a little earlier. So after we failed to add to an existing segment, just check that there is another one available instead of duplicating the bi_size check. Signed-off-by: Christoph Hellwig Reviewed-by: Jinyoung Choi Link: https://lore.kernel.org/r/20230724165433.117645-7-hch@lst.de Signed-off-by: Jens Axboe --- diff --git a/block/bio.c b/block/bio.c index 17f57fd2cff2f..d8e0e8de8cf4f 100644 --- a/block/bio.c +++ b/block/bio.c @@ -1126,7 +1126,7 @@ int bio_add_page(struct bio *bio, struct page *page, __bio_try_merge_page(bio, page, len, offset, &same_page)) return len; - if (bio_full(bio, len)) + if (bio->bi_vcnt >= bio->bi_max_vecs) return 0; __bio_add_page(bio, page, len, offset); return len;