From: Hannes Reinecke Date: Wed, 13 Jan 2021 09:04:54 +0000 (+0100) Subject: scsi: esp_scsi: Do not set SCSI message byte X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=809dadb15a9122f6bf175af166a46854825ecea5;p=linux.git scsi: esp_scsi: Do not set SCSI message byte The message byte setting always devolves to COMMAND_COMPLETE so we can drop setting the message byte in the SCSI result. Link: https://lore.kernel.org/r/20210113090500.129644-30-hare@suse.de Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c index 2bc7e990c1195..007ccef5d1e2f 100644 --- a/drivers/scsi/esp_scsi.c +++ b/drivers/scsi/esp_scsi.c @@ -907,10 +907,8 @@ static void esp_cmd_is_done(struct esp *esp, struct esp_cmd_entry *ent, esp_free_lun_tag(ent, dev->hostdata); cmd->result = 0; set_host_byte(cmd, host_byte); - if (host_byte == DID_OK) { - set_msg_byte(cmd, ent->message); + if (host_byte == DID_OK) set_status_byte(cmd, ent->status); - } if (ent->eh_done) { complete(ent->eh_done); @@ -926,7 +924,6 @@ static void esp_cmd_is_done(struct esp *esp, struct esp_cmd_entry *ent, */ cmd->result = ((DRIVER_SENSE << 24) | (DID_OK << 16) | - (COMMAND_COMPLETE << 8) | (SAM_STAT_CHECK_CONDITION << 0)); ent->flags &= ~ESP_CMD_FLAG_AUTOSENSE;