From: Zhihao Cheng <chengzhihao1@huawei.com>
Date: Tue, 3 Mar 2020 09:40:22 +0000 (+0800)
Subject: ubifs: ubifs_jnl_write_inode: Fix a memory leak bug
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=81423c78551654953d746250f1721300b470be0e;p=linux.git

ubifs: ubifs_jnl_write_inode: Fix a memory leak bug

When inodes with extended attributes are evicted, xent is not freed in one
exit branch.

Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Fixes: 9ca2d732644484488db3112 ("ubifs: Limit number of xattrs per inode")
Signed-off-by: Richard Weinberger <richard@nod.at>
---

diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
index 3bf8b1fda9d74..e5ec1afe1c668 100644
--- a/fs/ubifs/journal.c
+++ b/fs/ubifs/journal.c
@@ -905,6 +905,7 @@ int ubifs_jnl_write_inode(struct ubifs_info *c, const struct inode *inode)
 				ubifs_err(c, "dead directory entry '%s', error %d",
 					  xent->name, err);
 				ubifs_ro_mode(c, err);
+				kfree(xent);
 				goto out_release;
 			}
 			ubifs_assert(c, ubifs_inode(xino)->xattr);