From: Breno Leitao <leitao@debian.org>
Date: Tue, 27 Feb 2024 18:23:37 +0000 (-0800)
Subject: net: bridge: Exit if multicast_init_stats fails
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=82a48affb36f1fee36fe415051a8947d42861108;p=linux.git

net: bridge: Exit if multicast_init_stats fails

If br_multicast_init_stats() fails, there is no need to set lockdep
classes. Just return from the error path.

Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Link: https://lore.kernel.org/r/20240227182338.2739884-2-leitao@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c
index 4f636f7b05558..c366ccc8b3db7 100644
--- a/net/bridge/br_device.c
+++ b/net/bridge/br_device.c
@@ -135,10 +135,11 @@ static int br_dev_init(struct net_device *dev)
 		br_vlan_flush(br);
 		br_mdb_hash_fini(br);
 		br_fdb_hash_fini(br);
+		return err;
 	}
 
 	netdev_lockdep_set_classes(dev);
-	return err;
+	return 0;
 }
 
 static void br_dev_uninit(struct net_device *dev)