From: Christian Marangi Date: Sun, 19 Jun 2022 22:29:39 +0000 (+0200) Subject: PM / devfreq: Fix kernel warning with cpufreq passive register fail X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=82c66d2bbbeda9e493487e7413769087a0b46250;p=linux.git PM / devfreq: Fix kernel warning with cpufreq passive register fail Remove cpufreq_passive_unregister_notifier from cpufreq_passive_register_notifier in case of error as devfreq core already call unregister on GOV_START fail. This fix the kernel always printing a WARN on governor PROBE_DEFER as cpufreq_passive_unregister_notifier is called two times and return error on the second call as the cpufreq is already unregistered. Fixes: a03dacb0316f ("PM / devfreq: Add cpu based scaling support to passive governor") Signed-off-by: Christian Marangi Signed-off-by: Chanwoo Choi --- diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c index 406ef79c0c461..bce487cc8f3eb 100644 --- a/drivers/devfreq/governor_passive.c +++ b/drivers/devfreq/governor_passive.c @@ -330,7 +330,6 @@ err_free_cpu_data: err_put_policy: cpufreq_cpu_put(policy); err: - WARN_ON(cpufreq_passive_unregister_notifier(devfreq)); return ret; }