From: Borislav Petkov Date: Tue, 5 Feb 2019 11:05:45 +0000 (+0100) Subject: x86/boot: Fix cmdline_find_option() prototype visibility X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=82f9ed3a93307089242ff8a5c694e82c8c93f522;p=linux.git x86/boot: Fix cmdline_find_option() prototype visibility ac09c5f43cf6 ("x86/boot: Build the command line parsing code unconditionally") enabled building the command line parsing code unconditionally but it forgot to remove the respective ifdeffery around the prototypes in the misc.h header, leading to arch/x86/boot/compressed/acpi.c: In function ‘get_acpi_rsdp’: arch/x86/boot/compressed/acpi.c:37:8: warning: implicit declaration of function \ ‘cmdline_find_option’ [-Wimplicit-function-declaration] ret = cmdline_find_option("acpi_rsdp", val, MAX_ADDR_LEN); ^~~~~~~~~~~~~~~~~~~ for configs where neither CONFIG_EARLY_PRINTK nor CONFIG_RANDOMIZE_BASE was defined. Drop the ifdeffery in the header too. Fixes: ac09c5f43cf6 ("x86/boot: Build the command line parsing code unconditionally") Reported-by: kbuild test robot Signed-off-by: Borislav Petkov Cc: Chao Fan Cc: x86@kernel.org Link: https://lkml.kernel.org/r/5c51daf0.83pQEkvDZILqoSYW%lkp@intel.com Link: https://lkml.kernel.org/r/20190205131352.GA27396@zn.tnic --- diff --git a/arch/x86/boot/compressed/misc.h b/arch/x86/boot/compressed/misc.h index 19e8231a6fd6f..5b8d51996cdd3 100644 --- a/arch/x86/boot/compressed/misc.h +++ b/arch/x86/boot/compressed/misc.h @@ -66,11 +66,9 @@ static inline void debug_puthex(const char *s) #endif -#if CONFIG_EARLY_PRINTK || CONFIG_RANDOMIZE_BASE /* cmdline.c */ int cmdline_find_option(const char *option, char *buffer, int bufsize); int cmdline_find_option_bool(const char *option); -#endif struct mem_vector { unsigned long long start;