From: Bart Van Assche <bart.vanassche@wdc.com> Date: Fri, 25 Aug 2017 20:46:35 +0000 (-0700) Subject: scsi: sd: Remove a useless comparison X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=830cc351bc3c7f867daf92f17992bca34a647d8c;p=linux.git scsi: sd: Remove a useless comparison This patch avoids that gcc reports the following warning when building with W=1: drivers/scsi/sd.c:315:10: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] if (val >= 0 && val <= T10_PI_TYPE3_PROTECTION) Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> Reviewed-by: Hannes Reinecke <hare@suse.de> Cc: Christoph Hellwig <hch@lst.de> Cc: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> --- diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 8b3d7994e1826..7c0f9eb5a5fd6 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -312,7 +312,7 @@ protection_type_store(struct device *dev, struct device_attribute *attr, if (err) return err; - if (val >= 0 && val <= T10_PI_TYPE3_PROTECTION) + if (val <= T10_PI_TYPE3_PROTECTION) sdkp->protection_type = val; return count;