From: Jann Horn Date: Fri, 18 Oct 2019 15:39:46 +0000 (+0200) Subject: binder: Remove incorrect comment about vm_insert_page() behavior X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=834c7360f92ad88155c5628eb10d60419ebaa0df;p=linux.git binder: Remove incorrect comment about vm_insert_page() behavior vm_insert_page() does increment the page refcount, and just to be sure, I've confirmed it by printing page_count(page[0].page_ptr) before and after vm_insert_page(). It's 1 before, 2 afterwards, as expected. Fixes: a145dd411eb2 ("VM: add "vm_insert_page()" function") Signed-off-by: Jann Horn Acked-by: Christian Brauner Link: https://lore.kernel.org/r/20191018153946.128584-1-jannh@google.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c index d42a8b2f636a5..2faada3e97fde 100644 --- a/drivers/android/binder_alloc.c +++ b/drivers/android/binder_alloc.c @@ -267,7 +267,6 @@ static int binder_update_page_range(struct binder_alloc *alloc, int allocate, alloc->pages_high = index + 1; trace_binder_alloc_page_end(alloc, index); - /* vm_insert_page does not seem to increment the refcount */ } if (mm) { up_read(&mm->mmap_sem);