From: bep Date: Mon, 5 Jan 2015 11:44:41 +0000 (+0100) Subject: Add ERROR logging on invalid date and publishdate X-Git-Tag: v0.13~220 X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=837922d32bc1d0d2fbc50af07947e6b858df1550;p=brevno-suite%2Fhugo Add ERROR logging on invalid date and publishdate Having correct dates is important in Hugo. Previously date parsing errors were swallowed, leading to confusing results. This commit adds ERROR logging when date or publishdate in front matter cannot be parsed into a time.Time. --- diff --git a/hugolib/page.go b/hugolib/page.go index 7c189ca2..2ebc17b6 100644 --- a/hugolib/page.go +++ b/hugolib/page.go @@ -397,7 +397,7 @@ func (page *Page) update(f interface{}) error { return fmt.Errorf("no metadata found") } m := f.(map[string]interface{}) - + var err error for k, v := range m { loki := strings.ToLower(k) switch loki { @@ -421,9 +421,15 @@ func (page *Page) update(f interface{}) error { case "keywords": page.Keywords = cast.ToStringSlice(v) case "date": - page.Date = cast.ToTime(v) + page.Date, err = cast.ToTimeE(v) + if err != nil { + jww.ERROR.Printf("Failed to parse date '%v' in page %s", v, page.File.Path()) + } case "publishdate", "pubdate": - page.PublishDate = cast.ToTime(v) + page.PublishDate, err = cast.ToTimeE(v) + if err != nil { + jww.ERROR.Printf("Failed to parse publishdate '%v' in page %s", v, page.File.Path()) + } case "draft": page.Draft = cast.ToBool(v) case "layout":