From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 19 May 2021 14:17:45 +0000 (+0300)
Subject: w1: fix loop in w1_fini()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=83f3fcf96fcc7e5405b37d9424c7ef26bfa203f8;p=linux.git

w1: fix loop in w1_fini()

The __w1_remove_master_device() function calls:

	list_del(&dev->w1_master_entry);

So presumably this can cause an endless loop.

Fixes: 7785925dd8e0 ("[PATCH] w1: cleanups.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 074bbdb67f0e3..b651e42161e61 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -1253,10 +1253,10 @@ err_out_exit_init:
 
 static void __exit w1_fini(void)
 {
-	struct w1_master *dev;
+	struct w1_master *dev, *n;
 
 	/* Set netlink removal messages and some cleanup */
-	list_for_each_entry(dev, &w1_masters, w1_master_entry)
+	list_for_each_entry_safe(dev, n, &w1_masters, w1_master_entry)
 		__w1_remove_master_device(dev);
 
 	w1_fini_netlink();