From: Alexey Dobriyan Date: Tue, 14 May 2019 22:43:48 +0000 (-0700) Subject: fs//binfmt_elf.c: move variables initialization closer to their usage X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=852643165aea0999bb862b36511c5b9f6b11449f;p=linux.git fs//binfmt_elf.c: move variables initialization closer to their usage Link: http://lkml.kernel.org/r/20190416202002.GB24304@avx2 Signed-off-by: Alexey Dobriyan Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 3f18a7f9d49e5..512646da8255d 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -732,14 +732,6 @@ static int load_elf_binary(struct linux_binprm *bprm) goto out; elf_ppnt = elf_phdata; - elf_bss = 0; - elf_brk = 0; - - start_code = ~0UL; - end_code = 0; - start_data = 0; - end_data = 0; - for (i = 0; i < loc->elf_ex.e_phnum; i++, elf_ppnt++) { char *elf_interpreter; loff_t pos; @@ -887,6 +879,14 @@ out_free_interp: if (retval < 0) goto out_free_dentry; + elf_bss = 0; + elf_brk = 0; + + start_code = ~0UL; + end_code = 0; + start_data = 0; + end_data = 0; + /* Now we do a little grungy work by mmapping the ELF image into the correct location in memory. */ for(i = 0, elf_ppnt = elf_phdata;