From: Kent Overstreet Date: Thu, 18 Jul 2019 21:32:20 +0000 (-0400) Subject: bcachefs: Don't unlink iters on unsuccessful commit X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=8627f674bc98d6eeb91f885ca1259d29a0e7aa34;p=linux.git bcachefs: Don't unlink iters on unsuccessful commit Where unlink_on_commit is used, on unsuccessfull commit we're likely retrying the whole update and were going to be using the same iterators again. The management of multiple iterators needs to be gone over a fair bit more at some point... Signed-off-by: Kent Overstreet --- diff --git a/fs/bcachefs/btree_update_leaf.c b/fs/bcachefs/btree_update_leaf.c index 4461e42f2367a..b878f9a9882cb 100644 --- a/fs/bcachefs/btree_update_leaf.c +++ b/fs/bcachefs/btree_update_leaf.c @@ -923,8 +923,6 @@ out_noupdates: bch2_trans_unlink_iters(trans, ~trans->iters_touched| trans->iters_unlink_on_commit); trans->iters_touched = 0; - } else { - bch2_trans_unlink_iters(trans, trans->iters_unlink_on_commit); } trans->nr_updates = 0; trans->mem_top = 0;