From: Lars-Peter Clausen Date: Sat, 22 Jul 2023 23:08:44 +0000 (-0700) Subject: PCI: endpoint: Make struct pci_epf_ops in pci_epf_driver const X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=86362293044b382aece355f9e4e3f7116dcd1eae;p=linux.git PCI: endpoint: Make struct pci_epf_ops in pci_epf_driver const The pci_epf_ops struct contains a set of callbacks that are used by the pci_epf_driver, and is never modified by the EPF core itself. Marking the struct pointer const allows EPF drivers to declare their pci_epf_ops struct to be const. This allows the struct to be placed in the read-only section. Which for example brings some security benefits as the callbacks can not be overwritten. [kwilczynski: commit log] Link: https://lore.kernel.org/linux-pci/20230722230848.589428-1-lars@metafoo.de Signed-off-by: Lars-Peter Clausen Signed-off-by: Krzysztof Wilczyński Reviewed-by: Manivannan Sadhasivam --- diff --git a/include/linux/pci-epf.h b/include/linux/pci-epf.h index 3f44b6aec4770..764dc62b3acc9 100644 --- a/include/linux/pci-epf.h +++ b/include/linux/pci-epf.h @@ -98,7 +98,7 @@ struct pci_epf_driver { void (*remove)(struct pci_epf *epf); struct device_driver driver; - struct pci_epf_ops *ops; + const struct pci_epf_ops *ops; struct module *owner; struct list_head epf_group; const struct pci_epf_device_id *id_table;