From: kernel test robot <lkp@intel.com>
Date: Thu, 11 Feb 2021 01:27:31 +0000 (-0800)
Subject: xfs: fix boolreturn.cocci warnings
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=8646b982baf7d389a140ca3974974a4cbbc3f171;p=linux.git

xfs: fix boolreturn.cocci warnings

fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function 'xfs_log_need_covered' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 37444fc4cc39 ("xfs: lift writable fs check up into log worker task")
CC: Brian Foster <bfoster@redhat.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---

diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
index 9aa30e7cd3143..06041834daa31 100644
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -1069,7 +1069,7 @@ xfs_log_need_covered(
 	bool			needed = false;
 
 	if (!xlog_cil_empty(log))
-		return 0;
+		return false;
 
 	spin_lock(&log->l_icloglock);
 	switch (log->l_covered_state) {