From: Jason J. Herne Date: Fri, 30 Oct 2020 12:28:23 +0000 (+0100) Subject: s390-bios: Skip writing iplb location to low core for ccw ipl X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=872882e771cf0873f5e8e78ea7333367a3f87d8b;p=qemu.git s390-bios: Skip writing iplb location to low core for ccw ipl The architecture states that the iplb location is only written to low core for list directed ipl and not for traditional ccw ipl. If we don't skip this then operating systems that load by reading into low core memory may fail to start. We should also not write the iplb pointer for network boot as it might overwrite content that we got via network. Fixes: 9bfc04f9ef68 ("pc-bios: s390x: Save iplb location in lowcore") Signed-off-by: Jason J. Herne Signed-off-by: Christian Borntraeger Acked-by: Thomas Huth Message-Id: <20201030122823.347140-1-borntraeger@de.ibm.com> Signed-off-by: Cornelia Huck --- diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c index 43c792cf95..fc4bfaa455 100644 --- a/pc-bios/s390-ccw/main.c +++ b/pc-bios/s390-ccw/main.c @@ -43,7 +43,9 @@ void write_subsystem_identification(void) void write_iplb_location(void) { - lowcore->ptr_iplb = ptr2u32(&iplb); + if (cutype == CU_TYPE_VIRTIO && virtio_get_device_type() != VIRTIO_ID_NET) { + lowcore->ptr_iplb = ptr2u32(&iplb); + } } unsigned int get_loadparm_index(void)