From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 20 Apr 2018 14:52:39 +0000 (+0100)
Subject: hw/mips/boston.c: Don't create "null" chardevs for serial devices
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=87364af8fe0c9def2e9de8e63f6b66135834318c;p=qemu.git

hw/mips/boston.c: Don't create "null" chardevs for serial devices

Following commit 12051d82f004024, UART devices should handle
being passed a NULL pointer chardev, so we don't need to
create "null" backends in board code. Remove the code that
 does this and updates serial_hds[].

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180420145249.32435-4-peter.maydell@linaro.org
---

diff --git a/hw/mips/boston.c b/hw/mips/boston.c
index fb23161b33..14f0f6673b 100644
--- a/hw/mips/boston.c
+++ b/hw/mips/boston.c
@@ -505,10 +505,6 @@ static void boston_mach_init(MachineState *machine)
                           "boston-platregs", 0x1000);
     memory_region_add_subregion_overlap(sys_mem, 0x17ffd000, platreg, 0);
 
-    if (!serial_hds[0]) {
-        serial_hds[0] = qemu_chr_new("serial0", "null");
-    }
-
     s->uart = serial_mm_init(sys_mem, 0x17ffe000, 2,
                              get_cps_irq(s->cps, 3), 10000000,
                              serial_hds[0], DEVICE_NATIVE_ENDIAN);