From: Eric Biggers Date: Fri, 26 Aug 2022 05:04:56 +0000 (-0700) Subject: crypto: lib - remove unneeded selection of XOR_BLOCKS X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=874b301985ef2f89b8b592ad255e03fb6fbfe605;p=linux.git crypto: lib - remove unneeded selection of XOR_BLOCKS CRYPTO_LIB_CHACHA_GENERIC doesn't need to select XOR_BLOCKS. It perhaps was thought that it's needed for __crypto_xor, but that's not the case. Enabling XOR_BLOCKS is problematic because the XOR_BLOCKS code runs a benchmark when it is initialized. That causes a boot time regression on systems that didn't have it enabled before. Therefore, remove this unnecessary and problematic selection. Fixes: e56e18985596 ("lib/crypto: add prompts back to crypto libraries") Cc: stable@vger.kernel.org Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu --- diff --git a/lib/crypto/Kconfig b/lib/crypto/Kconfig index 9ff549f63540f..47816af9a9d7e 100644 --- a/lib/crypto/Kconfig +++ b/lib/crypto/Kconfig @@ -33,7 +33,6 @@ config CRYPTO_ARCH_HAVE_LIB_CHACHA config CRYPTO_LIB_CHACHA_GENERIC tristate - select XOR_BLOCKS help This symbol can be depended upon by arch implementations of the ChaCha library interface that require the generic code as a