From: Baolin Wang <baolin.wang@linux.alibaba.com>
Date: Sat, 4 Jul 2020 07:28:21 +0000 (+0800)
Subject: blk-mq: remove redundant validation in __blk_mq_end_request()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=87890092ee6504a49841d854ff81a71a85c19a5d;p=linux.git

blk-mq: remove redundant validation in __blk_mq_end_request()

We've already validated the 'q->elevator' before calling
->ops.completed_request() in blk_mq_sched_completed_request(), thus no
need to validate rq->internal_tag again. Rmove it.

Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/block/blk-mq.c b/block/blk-mq.c
index b6dd080d39625..c3856377b961e 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -544,8 +544,7 @@ inline void __blk_mq_end_request(struct request *rq, blk_status_t error)
 		blk_stat_add(rq, now);
 	}
 
-	if (rq->internal_tag != BLK_MQ_NO_TAG)
-		blk_mq_sched_completed_request(rq, now);
+	blk_mq_sched_completed_request(rq, now);
 
 	blk_account_io_done(rq, now);