From: Christoph Hellwig Date: Mon, 12 Jun 2023 05:35:15 +0000 (+0200) Subject: zonefs: set FMODE_CAN_ODIRECT instead of a dummy direct_IO method X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=8812387d056957355ef1d026cd38bed3830649db;p=linux.git zonefs: set FMODE_CAN_ODIRECT instead of a dummy direct_IO method Since commit a2ad63daa88b ("VFS: add FMODE_CAN_ODIRECT file flag") file systems can just set the FMODE_CAN_ODIRECT flag at open time instead of wiring up a dummy direct_IO method to indicate support for direct I/O. Do that for zonefs so that noop_direct_IO can eventually be removed. Signed-off-by: Christoph Hellwig Signed-off-by: Damien Le Moal --- diff --git a/fs/zonefs/file.c b/fs/zonefs/file.c index c34ec5b540539..d11b08d5e4d1b 100644 --- a/fs/zonefs/file.c +++ b/fs/zonefs/file.c @@ -181,7 +181,6 @@ const struct address_space_operations zonefs_file_aops = { .migrate_folio = filemap_migrate_folio, .is_partially_uptodate = iomap_is_partially_uptodate, .error_remove_page = generic_error_remove_page, - .direct_IO = noop_direct_IO, .swap_activate = zonefs_swap_activate, }; @@ -815,6 +814,7 @@ static int zonefs_file_open(struct inode *inode, struct file *file) { int ret; + file->f_mode |= FMODE_CAN_ODIRECT; ret = generic_file_open(inode, file); if (ret) return ret;