From: Jan Kara Date: Fri, 16 Jun 2023 16:50:56 +0000 (+0200) Subject: ext4: drop read-only check from ext4_force_commit() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=889860e452d7436ca72018b8a03cbd89c38d6384;p=linux.git ext4: drop read-only check from ext4_force_commit() JBD2 code will quickly return without doing anything when there's nothing to commit so there's no point in the read-only check in ext4_force_commit(). Just drop it. Signed-off-by: Jan Kara Link: https://lore.kernel.org/r/20230616165109.21695-10-jack@suse.cz Signed-off-by: Theodore Ts'o --- diff --git a/fs/ext4/super.c b/fs/ext4/super.c index a9a7c38c74423..4613264344b07 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -6270,13 +6270,7 @@ static int ext4_clear_journal_err(struct super_block *sb, */ int ext4_force_commit(struct super_block *sb) { - journal_t *journal; - - if (sb_rdonly(sb)) - return 0; - - journal = EXT4_SB(sb)->s_journal; - return ext4_journal_force_commit(journal); + return ext4_journal_force_commit(EXT4_SB(sb)->s_journal); } static int ext4_sync_fs(struct super_block *sb, int wait)