From: Sergey Shtylyov Date: Wed, 9 Feb 2022 21:46:30 +0000 (+0300) Subject: ata: sata_rcar: make sata_rcar_ata_devchk() return 'bool' X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=88e6b81878fb3fce93a26879164a2b7f5cbc848a;p=linux.git ata: sata_rcar: make sata_rcar_ata_devchk() return 'bool' sata_rcar_ata_devchk() returns 1 if a device is present, 0 if not -- the 'bool' type clearly fits better here than 'unsigned int'... Signed-off-by: Sergey Shtylyov Signed-off-by: Damien Le Moal --- diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c index be8bfefed663f..20263c1113df6 100644 --- a/drivers/ata/sata_rcar.c +++ b/drivers/ata/sata_rcar.c @@ -283,8 +283,7 @@ static void sata_rcar_dev_select(struct ata_port *ap, unsigned int device) ata_sff_pause(ap); /* needed; also flushes, for mmio */ } -static unsigned int sata_rcar_ata_devchk(struct ata_port *ap, - unsigned int device) +static bool sata_rcar_ata_devchk(struct ata_port *ap, unsigned int device) { struct ata_ioports *ioaddr = &ap->ioaddr; u8 nsect, lbal; @@ -304,9 +303,9 @@ static unsigned int sata_rcar_ata_devchk(struct ata_port *ap, lbal = ioread32(ioaddr->lbal_addr); if (nsect == 0x55 && lbal == 0xaa) - return 1; /* found a device */ + return true; /* found a device */ - return 0; /* nothing found */ + return false; /* nothing found */ } static int sata_rcar_wait_after_reset(struct ata_link *link,