From: wenxu <wenxu@ucloud.cn>
Date: Fri, 2 Jul 2021 03:34:31 +0000 (+0800)
Subject: net/sched: act_ct: fix err check for nf_conntrack_confirm
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=8955b90c3cdad199137809aac8ccbbb585355913;p=linux.git

net/sched: act_ct: fix err check for nf_conntrack_confirm

The confirm operation should be checked. If there are any failed,
the packet should be dropped like in ovs and netfilter.

Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct")
Signed-off-by: wenxu <wenxu@ucloud.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c
index a656baa321fe1..a62f404d0e165 100644
--- a/net/sched/act_ct.c
+++ b/net/sched/act_ct.c
@@ -1026,7 +1026,8 @@ do_nat:
 		/* This will take care of sending queued events
 		 * even if the connection is already confirmed.
 		 */
-		nf_conntrack_confirm(skb);
+		if (nf_conntrack_confirm(skb) != NF_ACCEPT)
+			goto drop;
 	}
 
 	if (!skip_add)