From: Yury Norov Date: Thu, 10 Feb 2022 22:49:07 +0000 (-0800) Subject: clocksource: Replace cpumask_weight() with cpumask_empty() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=8afbcaf8690dac19ebf570a4e4fef9c59c75bf8e;p=linux.git clocksource: Replace cpumask_weight() with cpumask_empty() clocksource_verify_percpu() calls cpumask_weight() to check if any bit of a given cpumask is set. This can be done more efficiently with cpumask_empty() because cpumask_empty() stops traversing the cpumask as soon as it finds first set bit, while cpumask_weight() counts all bits unconditionally. Signed-off-by: Yury Norov Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/20220210224933.379149-24-yury.norov@gmail.com --- diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index 95d7ca35bdf2c..cee5da1e54c41 100644 --- a/kernel/time/clocksource.c +++ b/kernel/time/clocksource.c @@ -343,7 +343,7 @@ void clocksource_verify_percpu(struct clocksource *cs) cpus_read_lock(); preempt_disable(); clocksource_verify_choose_cpus(); - if (cpumask_weight(&cpus_chosen) == 0) { + if (cpumask_empty(&cpus_chosen)) { preempt_enable(); cpus_read_unlock(); pr_warn("Not enough CPUs to check clocksource '%s'.\n", cs->name);