From: Colin Ian King <colin.king@canonical.com>
Date: Thu, 9 Sep 2021 12:35:41 +0000 (+0100)
Subject: Bluetooth: btintel: Fix incorrect out of memory check
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=8bba13b1d08d42e2e8308924fa5c1551a7b2b011;p=linux.git

Bluetooth: btintel: Fix incorrect out of memory check

Currently *ven_data is being assigned the return from a kmalloc call but
the out-of-memory check is checking ven_data and not *ven_data. Fix this
by adding the missing dereference * operator,

Addresses-Coverity: ("Dereference null return")
Fixes: 70dd978952bc ("Bluetooth: btintel: Define a callback to fetch codec config data")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---

diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index 115bb2d07a8d5..9359bff472965 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -2176,7 +2176,7 @@ static int btintel_get_codec_config_data(struct hci_dev *hdev,
 	}
 
 	*ven_data = kmalloc(sizeof(__u8), GFP_KERNEL);
-	if (!ven_data) {
+	if (!*ven_data) {
 		err = -ENOMEM;
 		goto error;
 	}