From: Darrick J. Wong <darrick.wong@oracle.com>
Date: Mon, 4 May 2020 21:06:27 +0000 (-0700)
Subject: xfs: clean up the error handling in xfs_swap_extents
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=8bc3b5e4b70d28f8edcafc3c9e4de515998eea9e;p=linux.git

xfs: clean up the error handling in xfs_swap_extents

Make sure we release resources properly if we cannot clean out the COW
extents in preparation for an extent swap.

Fixes: 96987eea537d6c ("xfs: cancel COW blocks before swapext")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---

diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c
index 4f800f7fe8882..cc23a3e23e2d1 100644
--- a/fs/xfs/xfs_bmap_util.c
+++ b/fs/xfs/xfs_bmap_util.c
@@ -1606,7 +1606,7 @@ xfs_swap_extents(
 	if (xfs_inode_has_cow_data(tip)) {
 		error = xfs_reflink_cancel_cow_range(tip, 0, NULLFILEOFF, true);
 		if (error)
-			return error;
+			goto out_unlock;
 	}
 
 	/*