From: Pawit Pornkitprasan <p.pawit@gmail.com>
Date: Mon, 29 Jul 2013 23:39:52 +0000 (+0900)
Subject: migration: don't use uninitialized variables
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=8c0426aed1d2279845e6a2c3355da8b5d9926cb6;p=qemu.git

migration: don't use uninitialized variables

The qmp_migrate method uses the 'blk' and 'inc' parameter without
checking if they're valid or not (they may be uninitialized if
command is received via QMP)

Signed-off-by: Pawit Pornkitprasan <p.pawit@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---

diff --git a/migration.c b/migration.c
index 3f682cdc7f..1402fa7680 100644
--- a/migration.c
+++ b/migration.c
@@ -400,8 +400,8 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk,
     MigrationParams params;
     const char *p;
 
-    params.blk = blk;
-    params.shared = inc;
+    params.blk = has_blk && blk;
+    params.shared = has_inc && inc;
 
     if (s->state == MIG_STATE_ACTIVE || s->state == MIG_STATE_SETUP) {
         error_set(errp, QERR_MIGRATION_ACTIVE);