From: Jan Kara <jack@suse.cz>
Date: Mon, 12 Nov 2018 14:54:48 +0000 (-0500)
Subject: audit: Remove pointless check in insert_hash()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=8cd0feb5234ccda3c15de35b40c8010a406dfc03;p=linux.git

audit: Remove pointless check in insert_hash()

The audit_tree_group->mark_mutex is held all the time while we create
the fsnotify mark, add it to the inode, and insert chunk into the hash.
Hence mark cannot get detached during this time and so the check whether
the mark is attached in insert_hash() is pointless.

Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Paul Moore <paul@paul-moore.com>
---

diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
index d8f6cfa0005b4..d150514ff15ee 100644
--- a/kernel/audit_tree.c
+++ b/kernel/audit_tree.c
@@ -184,8 +184,6 @@ static void insert_hash(struct audit_chunk *chunk)
 {
 	struct list_head *list;
 
-	if (!(chunk->mark.flags & FSNOTIFY_MARK_FLAG_ATTACHED))
-		return;
 	/*
 	 * Make sure chunk is fully initialized before making it visible in the
 	 * hash. Pairs with a data dependency barrier in READ_ONCE() in