From: Patrick Rudolph Date: Fri, 9 Sep 2022 12:59:53 +0000 (+0200) Subject: regulator: core: Prevent integer underflow X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=8d8e16592022c9650df8aedfe6552ed478d7135b;p=linux.git regulator: core: Prevent integer underflow By using a ratio of delay to poll_enabled_time that is not integer time_remaining underflows and does not exit the loop as expected. As delay could be derived from DT and poll_enabled_time is defined in the driver this can easily happen. Use a signed iterator to make sure that the loop exits once the remaining time is negative. Signed-off-by: Patrick Rudolph Link: https://lore.kernel.org/r/20220909125954.577669-1-patrick.rudolph@9elements.com Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index a8dab5a936070..28879f8974d9c 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2699,7 +2699,7 @@ static int _regulator_do_enable(struct regulator_dev *rdev) * return -ETIMEDOUT. */ if (rdev->desc->poll_enabled_time) { - unsigned int time_remaining = delay; + int time_remaining = delay; while (time_remaining > 0) { _regulator_delay_helper(rdev->desc->poll_enabled_time);