From: Mat Martineau <mathew.j.martineau@linux.intel.com>
Date: Tue, 8 Nov 2016 23:48:22 +0000 (-0800)
Subject: crypto: dh - Consistenly return negative error codes
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=8edda7d22a95caddcc66431e4564c7d03568da4d;p=linux.git

crypto: dh - Consistenly return negative error codes

Fix the single instance where a positive EINVAL was returned.

Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/crypto/dh.c b/crypto/dh.c
index 9d19360e71897..ddcb528ab2ccc 100644
--- a/crypto/dh.c
+++ b/crypto/dh.c
@@ -118,7 +118,7 @@ static int dh_compute_value(struct kpp_request *req)
 	if (req->src) {
 		base = mpi_read_raw_from_sgl(req->src, req->src_len);
 		if (!base) {
-			ret = EINVAL;
+			ret = -EINVAL;
 			goto err_free_val;
 		}
 	} else {