From: Bartosz Golaszewski <bartekgola@gmail.com>
Date: Sat, 12 Aug 2017 19:46:13 +0000 (+0200)
Subject: tests: re-enable a test case for gpiomon
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=8ee026ed2e85791ef225c265b19a4998fc7b8e46;p=qemu-gpiodev%2Flibgpiod.git

tests: re-enable a test case for gpiomon

The test case in which we verify if falling-edge events are correctly
ignored was failing due to a bug in the kernel. This has now been
fixed with commit df1e76f28ffe ("gpiolib: skip unwanted events, don't
convert them to opposite edge") and released in linux v4.12.6.

Re-enable the test and make this version a hard requirement for
running the test suite.

Signed-off-by: Bartosz Golaszewski <bartekgola@gmail.com>
---

diff --git a/tests/gpiod-test.c b/tests/gpiod-test.c
index 84317b0..944c3f0 100644
--- a/tests/gpiod-test.c
+++ b/tests/gpiod-test.c
@@ -36,8 +36,8 @@
 static const char mockup_devpath[] = "/devices/platform/gpio-mockup/gpiochip";
 
 static const unsigned int min_kern_major = 4;
-static const unsigned int min_kern_minor = 11;
-static const unsigned int min_kern_release = 0;
+static const unsigned int min_kern_minor = 12;
+static const unsigned int min_kern_release = 6;
 
 struct mockup_chip {
 	char *path;
diff --git a/tests/tests-gpiomon.c b/tests/tests-gpiomon.c
index 9d9b406..1a59f04 100644
--- a/tests/tests-gpiomon.c
+++ b/tests/tests-gpiomon.c
@@ -129,11 +129,6 @@ TEST_DEFINE(gpiomon_both_events_sigterm,
 	    "tools: gpiomon - receive both types of events and kill with SIGTERM",
 	    0, { 8, 8 });
 
-/*
- * TODO There's a bug in the kernel with filtering out unwanted events. Until
- * it gets fixed, we must skip this test case.
- */
-#if 0
 static void gpiomon_ignore_falling_edge(void)
 {
 	test_tool_run("gpiomon", "--rising-edge",
@@ -151,7 +146,6 @@ static void gpiomon_ignore_falling_edge(void)
 TEST_DEFINE(gpiomon_ignore_falling_edge,
 	    "tools: gpiomon - wait for rising edge events, ignore falling edge",
 	    0, { 8, 8 });
-#endif
 
 static void gpiomon_watch_multiple_lines(void)
 {