From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Date: Mon, 5 Oct 2020 14:52:12 +0000 (+0800)
Subject: ipmi_si: Fix wrong return value in try_smi_init()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=8fe7990ceda8597e407d06bffc4bdbe835a93ece;p=linux.git

ipmi_si: Fix wrong return value in try_smi_init()

On an error exit path, a negative error code should be returned
instead of a positive return value.

Fixes: 90b2d4f15ff7 ("ipmi_si: Remove hacks for adding a dummy platform devices")
Cc: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Message-Id: <20201005145212.84435-1-tianjia.zhang@linux.alibaba.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 0b3dbc7e39fdc..5eac94cf4ff89 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -1980,7 +1980,7 @@ static int try_smi_init(struct smi_info *new_smi)
 	/* Do this early so it's available for logs. */
 	if (!new_smi->io.dev) {
 		pr_err("IPMI interface added with no device\n");
-		rv = EIO;
+		rv = -EIO;
 		goto out_err;
 	}