From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 27 Aug 2019 14:00:13 +0000 (-0300)
Subject: media: stm32-dcmi: Delete an unnecessary of_node_put() call in dcmi_probe()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=90499a230d16e48282fc78591fd33461d8741fb6;p=linux.git

media: stm32-dcmi: Delete an unnecessary of_node_put() call in dcmi_probe()

A null pointer would be passed to a call of the function “of_node_put”
immediately after a call of the function “of_graph_get_next_endpoint”
failed at one place.
Remove this superfluous function call.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---

diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
index cb1daf8217ff1..9392e3409fba0 100644
--- a/drivers/media/platform/stm32/stm32-dcmi.c
+++ b/drivers/media/platform/stm32/stm32-dcmi.c
@@ -1861,7 +1861,6 @@ static int dcmi_probe(struct platform_device *pdev)
 	np = of_graph_get_next_endpoint(np, NULL);
 	if (!np) {
 		dev_err(&pdev->dev, "Could not find the endpoint\n");
-		of_node_put(np);
 		return -ENODEV;
 	}