From: Paolo Bonzini <pbonzini@redhat.com>
Date: Tue, 16 Feb 2016 07:49:15 +0000 (+0100)
Subject: mptsas: fix wrong formula
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9155b7606a17967b1e056aa5d0433a047f23ae51;p=qemu.git

mptsas: fix wrong formula

MPI_DOORBELL_WHO_INIT_SHIFT is being repeated twice.  Reported
by Coverity.

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c
index 1ce32261b5..499c1465ae 100644
--- a/hw/scsi/mptsas.c
+++ b/hw/scsi/mptsas.c
@@ -824,7 +824,7 @@ static uint32_t mptsas_doorbell_read(MPTSASState *s)
 {
     uint32_t ret;
 
-    ret = (s->who_init << MPI_DOORBELL_WHO_INIT_SHIFT) & MPI_DOORBELL_WHO_INIT_SHIFT;
+    ret = (s->who_init << MPI_DOORBELL_WHO_INIT_SHIFT) & MPI_DOORBELL_WHO_INIT_MASK;
     ret |= s->state;
     switch (s->doorbell_state) {
     case DOORBELL_NONE: