From: Eric Dumazet <edumazet@google.com>
Date: Sat, 16 Mar 2019 20:09:53 +0000 (-0700)
Subject: tun: add a missing rcu_read_unlock() in error path
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9180bb4f046064dfa4541488102703b402bb04e1;p=linux.git

tun: add a missing rcu_read_unlock() in error path

In my latest patch I missed one rcu_read_unlock(), in case
device is down.

Fixes: 4477138fa0ae ("tun: properly test for IFF_UP")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 0d343359f647f..e9ca1c088d0b1 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -1960,6 +1960,7 @@ drop:
 	rcu_read_lock();
 	if (unlikely(!(tun->dev->flags & IFF_UP))) {
 		err = -EIO;
+		rcu_read_unlock();
 		goto drop;
 	}