From: Al Viro Date: Mon, 5 Sep 2022 04:39:23 +0000 (-0400) Subject: [elf][regset] clean fill_note_info() a bit X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=922ef161b21e605bf803f65dc928fabefb735702;p=linux.git [elf][regset] clean fill_note_info() a bit *info is already initialized... Signed-off-by: Al Viro --- diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 002fd713ac118..4190dafd2ec44 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1833,24 +1833,17 @@ static int fill_note_info(struct elfhdr *elf, int phdrs, struct elf_thread_core_info *t; struct elf_prpsinfo *psinfo; struct core_thread *ct; - unsigned int i; - - info->size = 0; - info->thread = NULL; psinfo = kmalloc(sizeof(*psinfo), GFP_KERNEL); - if (psinfo == NULL) { - info->psinfo.data = NULL; /* So we don't free this wrongly */ + if (!psinfo) return 0; - } - fill_note(&info->psinfo, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo); /* * Figure out how many notes we're going to need for each thread. */ info->thread_notes = 0; - for (i = 0; i < view->n; ++i) + for (int i = 0; i < view->n; ++i) if (view->regsets[i].core_note_type != 0) ++info->thread_notes;