From: Miquel Raynal Date: Fri, 13 Nov 2020 12:39:45 +0000 (+0100) Subject: mtd: nand: Change dependency between the NAND and ECC cores X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=928f0736e9aa19488e030e408dde308507fe8bc1;p=linux.git mtd: nand: Change dependency between the NAND and ECC cores The NAND ECC core is included in the generic NAND core when it is compiled in. Different software ECC engines drivers will select the NAND ECC core and thus also have a dependency on the NAND core. Using a "depends on" between the two leads to possible cases (not real cases, but created by robots) where one is still unselected because of the "select does not verifies depends on" game: WARNING: unmet direct dependencies detected for MTD_NAND_ECC Depends on [n]: MTD [=m] && MTD_NAND_CORE [=n] Selected by [m]: - MTD_NAND_ECC_SW_HAMMING [=y] && MTD [=m] - MTD_NAND_ECC_SW_BCH [=y] && MTD [=m] Fix this by using a select instead. Reported-by: Randy Dunlap Signed-off-by: Miquel Raynal Acked-by: Randy Dunlap # build-tested Link: https://lore.kernel.org/linux-mtd/20201113123945.32592-1-miquel.raynal@bootlin.com --- diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 15ffe1a1b8631..b40455234cbd4 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -13,7 +13,7 @@ menu "ECC engine support" config MTD_NAND_ECC bool - depends on MTD_NAND_CORE + select MTD_NAND_CORE config MTD_NAND_ECC_SW_HAMMING bool "Software Hamming ECC engine"