From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Sat, 16 Sep 2023 16:12:35 +0000 (+0200)
Subject: spi: Drop warning from spi_stop_queue()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9386c958beb77aee0d95d5fd0c79babd06a86c7d;p=linux.git

spi: Drop warning from spi_stop_queue()

Both callers of spi_stop_queue() (i.e. spi_destroy_queue() and
spi_controller_suspend()) already emit an error message if
spi_stop_queue() fails. Another warning in this case isn't helpful, so
drop it.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230916161235.1050176-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
---

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 8d6304cb061ec..ac518be34917b 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2093,10 +2093,6 @@ static int spi_stop_queue(struct spi_controller *ctlr)
 
 	spin_unlock_irqrestore(&ctlr->queue_lock, flags);
 
-	if (ret) {
-		dev_warn(&ctlr->dev, "could not stop message queue\n");
-		return ret;
-	}
 	return ret;
 }