From: Darrick J. Wong Date: Fri, 21 Feb 2020 15:40:44 +0000 (-0800) Subject: xfs: improve error message when we can't allocate memory for xfs_buf X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=93baa55af1a19a4b86129fea40bc36c82f8b9905;p=linux.git xfs: improve error message when we can't allocate memory for xfs_buf If xfs_buf_get_map can't allocate enough memory for the buffer it's trying to create, it'll cough up an error about not being able to allocate "pagesn". That's not particularly helpful (and if we're really out of memory the message is very spammy) so change the message to tell us how many pages were actually requested, and ratelimit it too. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig --- diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index 217e4f82a44a2..c805ffae89130 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -727,8 +727,9 @@ found: if (!bp->b_addr) { error = _xfs_buf_map_pages(bp, flags); if (unlikely(error)) { - xfs_warn(target->bt_mount, - "%s: failed to map pagesn", __func__); + xfs_warn_ratelimited(target->bt_mount, + "%s: failed to map %u pages", __func__, + bp->b_page_count); xfs_buf_relse(bp); return error; }