From: Peter Xu Date: Mon, 26 Mar 2018 06:38:57 +0000 (+0800) Subject: qapi: restrict allow-oob value to be "true" X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9408860165e07aaadec66c336f3dc849b945a8ed;p=qemu.git qapi: restrict allow-oob value to be "true" It was missed in the first version of OOB series. We should check this to make sure we throw the right error when fault value is passed in. Signed-off-by: Peter Xu Message-Id: <20180326063901.27425-5-peterx@redhat.com> Reviewed-by: Marc-André Lureau Reviewed-by: Eric Blake Signed-off-by: Eric Blake --- diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index 2c05e3c284..3e14bc41f2 100644 --- a/scripts/qapi/common.py +++ b/scripts/qapi/common.py @@ -872,7 +872,7 @@ def check_keys(expr_elem, meta, required, optional=[]): raise QAPISemError(info, "'%s' of %s '%s' should only use false value" % (key, meta, name)) - if key == 'boxed' and value is not True: + if (key == 'boxed' or key == 'allow-oob') and value is not True: raise QAPISemError(info, "'%s' of %s '%s' should only use true value" % (key, meta, name))