From: Jens Axboe <axboe@kernel.dk>
Date: Mon, 29 Jan 2024 03:52:21 +0000 (-0700)
Subject: io_uring/rw: remove dead file == NULL check
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=949249e25f1098315a971b70b893c1a2e2e4a819;p=linux.git

io_uring/rw: remove dead file == NULL check

Any read/write opcode has needs_file == true, which means that we
would've failed the request long before reaching the issue stage if we
didn't successfully assign a file. This check has been dead forever,
and is really a leftover from generic code.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/io_uring/rw.c b/io_uring/rw.c
index 0fb7a045163ae..8ba93fffc23ac 100644
--- a/io_uring/rw.c
+++ b/io_uring/rw.c
@@ -721,7 +721,7 @@ static int io_rw_init_file(struct io_kiocb *req, fmode_t mode)
 	struct file *file = req->file;
 	int ret;
 
-	if (unlikely(!file || !(file->f_mode & mode)))
+	if (unlikely(!(file->f_mode & mode)))
 		return -EBADF;
 
 	if (!(req->flags & REQ_F_FIXED_FILE))