From: Sahitya Tummala Date: Mon, 29 Jul 2019 05:20:26 +0000 (+0530) Subject: f2fs: Fix indefinite loop in f2fs_gc() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=957fa47823dfe449c5a15a944e4e7a299a6601db;p=linux.git f2fs: Fix indefinite loop in f2fs_gc() Policy - foreground GC, LFS mode and greedy GC mode. Under this policy, f2fs_gc() loops forever to GC as it doesn't have enough free segements to proceed and thus it keeps calling gc_more for the same victim segment. This can happen if the selected victim segment could not be GC'd due to failed blkaddr validity check i.e. is_alive() returns false for the blocks set in current validity map. Fix this by not resetting the sbi->cur_victim_sec to NULL_SEGNO, when the segment selected could not be GC'd. This helps to select another segment for GC and thus helps to proceed forward with GC. [Note] This can happen due to is_alive as well as atomic_file which skipps GC. Signed-off-by: Sahitya Tummala Signed-off-by: Jaegeuk Kim --- diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index e88f98ddf396b..5877bd7296896 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -1326,7 +1326,7 @@ gc_more: round++; } - if (gc_type == FG_GC) + if (gc_type == FG_GC && seg_freed) sbi->cur_victim_sec = NULL_SEGNO; if (sync)