From: Bjorn Andersson Date: Fri, 21 Jul 2023 16:49:01 +0000 (-0700) Subject: soundwire: qcom: Log clk_get("iface") failures X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=95b0f3aa71eb09d067d89395fdb7f2dd87feae18;p=linux.git soundwire: qcom: Log clk_get("iface") failures Failing to acquire the iface clock makes probing of the Qualcomm SoundWire driver fail without providing any indication to the user. Make the driver log the error to aid debugging system configuration issues. Signed-off-by: Bjorn Andersson Reviewed-by: Andrew Halaney Link: https://lore.kernel.org/r/20230721164901.2155287-1-quic_bjorande@quicinc.com Signed-off-by: Vinod Koul --- diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index d0bb995a59ef4..a1e2d6c981862 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -1562,7 +1562,7 @@ static int qcom_swrm_probe(struct platform_device *pdev) ctrl->hclk = devm_clk_get(dev, "iface"); if (IS_ERR(ctrl->hclk)) { - ret = PTR_ERR(ctrl->hclk); + ret = dev_err_probe(dev, PTR_ERR(ctrl->hclk), "unable to get iface clock\n"); goto err_init; }