From: Alban Bedel Date: Mon, 28 Jan 2019 15:55:04 +0000 (+0000) Subject: nvmem: core: Always reference the device returned by nvmem_device_get() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=95b65195d571ab589a6d6893a418922757e06399;p=linux.git nvmem: core: Always reference the device returned by nvmem_device_get() In nvmem_device_get(), when the device lookup fails with DT it currently fallback on nvmem_find() which is wrong for two reasons. First nvmem_find() return NULL when nothing is found instead of an ERR_PTR. But nvmem_find() also just lookup the device, it doesn't reference the module and increment the reference count like it is done in the DT path. To fix this we replace the call to nvmem_find() with a call to __nvmem_device_get() which does all the referencing and return a proper ERR_PTR in case of error. Signed-off-by: Alban Bedel Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index a749a5cb0a4e3..1752768dd2d2a 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -874,7 +874,7 @@ struct nvmem_device *nvmem_device_get(struct device *dev, const char *dev_name) } - return nvmem_find(dev_name); + return __nvmem_device_get(NULL, dev_name); } EXPORT_SYMBOL_GPL(nvmem_device_get);