From: Markus Armbruster <armbru@redhat.com>
Date: Fri, 15 May 2015 11:59:02 +0000 (+0200)
Subject: tap: Finish conversion of tap_open() to Error
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=95c35a74fea51e307f6a3967e465a22776056b7e;p=qemu.git

tap: Finish conversion of tap_open() to Error

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 1431691143-1015-15-git-send-email-armbru@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---

diff --git a/net/tap.c b/net/tap.c
index 362df4235f..c1ee4f1233 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -597,10 +597,6 @@ static int net_tap_init(const NetdevTapOptions *tap, int *vnet_hdr,
     TFR(fd = tap_open(ifname, ifname_sz, vnet_hdr, vnet_hdr_required,
                       mq_required, errp));
     if (fd < 0) {
-        /* FIXME drop when all tap_open() store an Error */
-        if (errp && !*errp) {
-            error_setg(errp, "can't open tap device");
-        }
         return -1;
     }