From: Peter Maydell Date: Tue, 15 Feb 2011 13:44:45 +0000 (+0000) Subject: target-arm: Fix saturated values for Neon right shifts X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=960e623bfd45c92ce165177b8a0e748867fe5878;p=qemu.git target-arm: Fix saturated values for Neon right shifts Fix value returned by signed 8 and 16 bit qrshl helpers when the result has saturated. Signed-off-by: Peter Maydell Signed-off-by: Aurelien Jarno --- diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c index c97aa7dbd4..235a32c670 100644 --- a/target-arm/neon_helper.c +++ b/target-arm/neon_helper.c @@ -886,7 +886,10 @@ uint64_t HELPER(neon_qrshl_u64)(CPUState *env, uint64_t val, uint64_t shiftop) dest = src1 << tmp; \ if ((dest >> tmp) != src1) { \ SET_QC(); \ - dest = src1 >> 31; \ + dest = (uint32_t)(1 << (sizeof(src1) * 8 - 1)); \ + if (src1 > 0) { \ + dest--; \ + } \ } \ }} while (0) NEON_VOP_ENV(qrshl_s8, neon_s8, 4)