From: Marijn Suijten Date: Mon, 15 Nov 2021 20:34:56 +0000 (+0100) Subject: backlight: qcom-wled: Remove unnecessary 4th default string in WLED3 X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=96571489a06999bf5c62e2058622990734556f8f;p=linux.git backlight: qcom-wled: Remove unnecessary 4th default string in WLED3 The previous commit improves num_strings parsing to not go over the maximum of 3 strings for WLED3 anymore. Likewise this default index for a hypothetical 4th string is invalid and could access registers that are not mapped to the desired purpose. Removing this value gets rid of undesired confusion and avoids the possibility of accessing registers at this offset even if the 4th array element is used by accident. Signed-off-by: Marijn Suijten Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Daniel Thompson Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20211115203459.1634079-7-marijn.suijten@somainline.org --- diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index 5306b06044b4f..5c5df5a3deab5 100644 --- a/drivers/video/backlight/qcom-wled.c +++ b/drivers/video/backlight/qcom-wled.c @@ -948,7 +948,7 @@ static const struct wled_config wled3_config_defaults = { .cs_out_en = false, .ext_gen = false, .cabc = false, - .enabled_strings = {0, 1, 2, 3}, + .enabled_strings = {0, 1, 2}, }; static int wled4_setup(struct wled *wled)