From: Sergio Paracuellos Date: Wed, 5 May 2021 12:17:28 +0000 (+0200) Subject: staging: mt7621-pci: avoid to set gpio mode in driver X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=96c310c1a2b69faa958e7400c086631df4d57cc9;p=linux.git staging: mt7621-pci: avoid to set gpio mode in driver Gpio mode for the pcie pins must be request from device tree using pinctrl driver. Pinctrl driver is already setting this pcie pins as GPIO if it is requested. Hence, remove it from here. Signed-off-by: Sergio Paracuellos Link: https://lore.kernel.org/r/20210505121736.6459-3-sergio.paracuellos@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c index f490c7a1397d6..984e333408a0c 100644 --- a/drivers/staging/mt7621-pci/pci-mt7621.c +++ b/drivers/staging/mt7621-pci/pci-mt7621.c @@ -36,9 +36,6 @@ #include "../../pci/pci.h" -/* sysctl */ -#define MT7621_GPIO_MODE 0x60 - /* MediaTek specific configuration registers */ #define PCIE_FTS_NUM 0x70c #define PCIE_FTS_NUM_MASK GENMASK(15, 8) @@ -79,8 +76,6 @@ #define PCIE_PORT_INT_EN(x) BIT(20 + (x)) #define PCIE_PORT_LINKUP BIT(0) -#define PERST_MODE_MASK GENMASK(11, 10) -#define PERST_MODE_GPIO BIT(10) #define PERST_DELAY_MS 100 /** @@ -478,8 +473,6 @@ static void mt7621_pcie_init_ports(struct mt7621_pcie *pcie) struct mt7621_pcie_port *port, *tmp; int err; - rt_sysc_m32(PERST_MODE_MASK, PERST_MODE_GPIO, MT7621_GPIO_MODE); - mt7621_pcie_reset_assert(pcie); mt7621_pcie_reset_rc_deassert(pcie);