From: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Wed, 20 Apr 2022 13:26:19 +0000 (+0400)
Subject: util: use qemu_write_full() in qemu_write_pidfile()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=96eb9b2b47ecd923ff67848c0b1a92a900f95d91;p=qemu.git

util: use qemu_write_full() in qemu_write_pidfile()

Mostly for correctness.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-37-marcandre.lureau@redhat.com>
---

diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index fd2bdc9ac7..9751bc6be9 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -184,7 +184,7 @@ bool qemu_write_pidfile(const char *path, Error **errp)
     }
 
     snprintf(pidstr, sizeof(pidstr), FMT_pid "\n", getpid());
-    if (write(fd, pidstr, strlen(pidstr)) != strlen(pidstr)) {
+    if (qemu_write_full(fd, pidstr, strlen(pidstr)) != strlen(pidstr)) {
         error_setg(errp, "Failed to write pid file");
         goto fail_unlink;
     }